EFIDynoTuning Forum

Thank you for the updated version.

Finally got the chance to run 4.14.1, happens to be on CARD, 382 user named Subs chuck a warning.

I'm wondering what the rationale is behind this new feature and what it adds to the various ways of identifying user Sub commands?

CMT already notes user commanded Sub names by appending #cmd; SAD's default naming has the underscore between Sub and the address. I place the underscore after the address in DIR , oh and in many cases it has a name appended. It also questions the golden rule, "User Is King ".

It seems redundant twice over, what am I missing?

Can we have a setopts to silence it please?

BOOSTEDEVERYTHING wrote: ↑2025 Mar 07, 16:17 Quick update to my CRAI8 and READ0 DIR files.

Thank you for the update.

This has more Subs added from doing some tests for more complete Sub Discovery. It'll be the last for V4.13(10)
Warts and all;

That's a bug.

The warning should only come up if there is a duplicate USER command. It doesn't happen in my current 14.2 development code. I think it's an error flag which gets set and isn't cleared, and I fixed it when looking at something else. Not 100% sure. If so, this error probably reports for every SYM command, but possibly after there is a real error to set the flag first. So it's WRONG.

To confirm rules
User commands are always King/top and cannot be changed (*1), then a defined set of others come next (things like function lookup names, interrupt handlers etc) and then lowest precedent are 'default' names like "sub_1234".

(*1) but it's 'layered'. If you just set a name (e.g for a subroutine), SAD will still add extras (e.g. arguments) as user didn't specify. Whatever user command specifies effectively becomes absolute, no matter what, even if it breaks things.

Ok cool, a bug it is.

Thanks for the rules confirmation

4.14.1

Can confirm that there's several likely 'symbol' bugs , because -

1. Code doesn't always keep track of read vs write operand properly.
2. Error status does not always get cleared properly (leads to all those phantom error messages)
3. When looking up a symbol, doesn't always identify the correct field or default name (also read/write? still trying to nail this down)

Note - the 'add' (i.e. when specified in commands) process works correctly as far as I can tell, so it's in the 'find' where it goes wrong.

Working on this now, after a delay, for various everyday garbage...

Andy.

Yeah, seeing enough bugs to stick with 4.13(.10) for now. Looking forward to the fixes in the next release, thank you.

Quick note to everyone -

4.14 has a lot of regression bugs, and will for a while, as I am moving in version 5 code so I can add some of that functionality (i.e. calculations). For now stick with 4.13 for best results (now in main branch in GitHub) , but do have a play with 4.14 if you wish. Bug reports are welcome.

Special thanks to jsa for his time spent doing testing and bug finding.

Thanks.

Thank you TVRfan for the upgrades going into 4.14.

Yeah, 4.13 is the best version for disassembly until the bugs are cleaned out of 4.14.

Plenty of bugs to around, lol, I don't mind sharing!

Boosted,

Been running your OMAE2/EKO2 DIR against SADV4.14.2 for testing.

I'm seeing a lot of duplicates reported in MSG, so it would be worthwhile fixing those if you have not already.

These commands with a digit in front of the name are no good as well.

jsa wrote: ↑2025 Apr 28, 03:32 Boosted,

Been running your OMAE2/EKO2 DIR against SADV4.14.2 for testing.

I'm seeing a lot of duplicates reported in MSG, so it would be worthwhile fixing those if you have not already.

These commands with a digit in front of the name are no good as well.

Code: Select all

SYM   389 1"M9_VIN_REQ"                :B2#                               # {7}

That's not super surprising. LOL. I will go through them and get rid of duplicates. The ones with a digit in front of the name have to be typos, I will fix those. I will post an update on it soon. I haven't had any duplicates reported in my message file, but will double check the version of SAD I am using. Thanks for the heads up.

Edit: After looking over the EKO2 DIR file, I honestly have no idea where the 1's and 2's came from at all. I was messing around with SADX a bit, I wonder if it may have put those in there somehow? Also, I seem to have several DIR files for OMAE2, So I need to find software that will compare all the differences in the files and just show me what is different, and I will try and combine them. Not sure what happened there. It has been a while since I worked on that one, I have recently been working more on CRAI8 and READ0.