EFIDynoTuning Forum

The examples above are they the 256 or 257 characters on the line.

Honestly, I am not sure. I will have to find a way to get a count. I don't see anything in notepad or notepad++ that shows a character count per line. Do you know where it may be? I am sure I am just missing it somewhere. Are they limited to 256 Characters per line? I may have gotten a bit carried away with the descriptions. I copied and pasted from the Ford workshop manual.

In notetab the cursor position is given, so if the cursor is positioned at the end of the line, line length is known.

IIRC, tvrfan and I had a discussion way back when about line length and the number 256 comes to mind now. I haven't looked in the SAD manual to see if it's stated.

A short description or note is all that was intended for the comment after a command in DIR. With multiple windows for dir, cmt and lst open side by side, really long comments in DIR become unwieldy.

Definition files have short and long comment or description fields, the DIR comment would suit a short comment field. There are character limits in the fields of definition files. Looking at BE just now, it's 255 characters for the short description.

Yes, it's desieable to have a full description and instruction in the definition long comment field. Because the code purpose is common across many strategies, it would be better to have a 'database' of symbol names and long descriptions. When the definition is generated from DIR, the symbol name would be used to retrieve the associated long description. The short description could also be in the same database as well as other related fields.

Shoot! Now I have to figure out how to build a database. Lol. Some of the codes in the lst file I can’t find in the workshop manuals. I know ford was known to not have some codes in publications. I may try and reach out to an Engineer friend at Ford to see if there is a master list that wasn’t in the service publications.

A 'database' can be as simple as a csv file, a spreadsheet, a xml file or as complex as you like.

An xdf definition is based on xml and a database of sorts.

No doubt comprehensive lists exist, no harm in asking.

Ok....turns out they were most definitely too long, fixed my description lines and got that sorted out.
But, I have another question/request....I am having issues with correcting args in my dir file. could you please show me an example of how to determine correct size and how to correct it please? I will give a couple examples below or some I know should be a different size than what SAD has defined....

OMAE2

Code: Select all

09e0a: ef,a3,16           call  8b4b0            Sub_8b4b0 (
09e0d: 24,00                    #arg 1              TEMP0L,
09e0f: 59                       #arg 2              59,
09e10: 14                       #arg 3              14,
09e11: 01                       #arg 4              1,
09e12: 80                       #arg 5              80,
09e13: 19                       #arg 6              19 );
09e14: 10,08              rombk 8
09e16: ef,97,16           call  8b4b0            Sub_8b4b0 (
09e19: 24,00                    #arg 1              TEMP0L,
09e1b: 59                       #arg 2              59,
09e1c: 14                       #arg 3              14,
09e1d: 04                       #arg 4              4,
09e1e: 40                       #arg 5              40,
09e1f: 1a                       #arg 6              1a );
09e20: 10,08              rombk 8
09e22: ef,8b,16           call  8b4b0            Sub_8b4b0 (
09e25: 24,00                    #arg 1              TEMP0L,
09e27: 59                       #arg 2              59,
09e28: 14                       #arg 3              14,
09e29: 02                       #arg 4              2,
09e2a: 20                       #arg 5              20,
09e2b: 1b                       #arg 6              1b );
09e2c: 10,08              rombk 8
09e2e: ef,7f,16           call  8b4b0            Sub_8b4b0 (
09e31: 24,00                    #arg 1              TEMP0L,
09e33: 59                       #arg 2              59,
09e34: 14                       #arg 3              14,
09e35: 08                       #arg 4              8,
09e36: 10                       #arg 5              10,
09e37: 1c                       #arg 6              1c );

I feel like all of these should definitely be word sized args ( arg 2 and arg 3) should be combined....
Compared to RZASA.......

Code: Select all

0bf69: ef,47,ad           call  96cb3            Sub_96cb3 (
0bf6c: 24,00                    #arg 1              TEMP0L,
0bf6e: 6a,10                    #arg 2              106a,
0bf70: 01                       #arg 3              1,
0bf71: 80                       #arg 4              80,
0bf72: 19                       #arg 5              19 );
0bf73: 10,09              rombk 9
0bf75: ef,3b,ad           call  96cb3            Sub_96cb3 (
0bf78: 24,00                    #arg 1              TEMP0L,
0bf7a: 6a,10                    #arg 2              106a,
0bf7c: 04                       #arg 3              4,
0bf7d: 40                       #arg 4              40,
0bf7e: 1a                       #arg 5              1a );
0bf7f: 10,09              rombk 9
0bf81: ef,2f,ad           call  96cb3            Sub_96cb3 (
0bf84: 24,00                    #arg 1              TEMP0L,
0bf86: 6a,10                    #arg 2              106a,
0bf88: 02                       #arg 3              2,
0bf89: 20                       #arg 4              20,
0bf8a: 1b                       #arg 5              1b );
0bf8b: 10,09              rombk 9
0bf8d: ef,23,ad           call  96cb3            Sub_96cb3 (
0bf90: 24,00                    #arg 1              TEMP0L,
0bf92: 6a,10                    #arg 2              106a,
0bf94: 08                       #arg 3              8,
0bf95: 10                       #arg 4              10,
0bf96: 1c                       #arg 5              1c );

This is one I am not sure if the size of the args are correct or not....
OMAE2

0da80: ef,de,1d call 0f861 Sub889 (
0da83: 8a #arg 1 8a,
0da84: 0a #arg 2 a,
0da85: 8a #arg 3 8a,
0da86: 0a #arg 4 a,
0da87: 91 #arg 5 91,
0da88: 08 #arg 6 8,
0da89: 02 #arg 7 2 ); }
0da8a: f3 popp PSW = pop();

RZASA

Code: Select all

0d85f: ef,3b,1e           call  0f69d            Sub889 (
0d862: a4                       #arg 1              a4,
0d863: 0a                       #arg 2              a,
0d864: a4                       #arg 3              a4,
0d865: 0a                       #arg 4              a,
0d866: 52                       #arg 5              52,
0d867: 07                       #arg 6              7,
0d868: 02                       #arg 7              2 ); }
0d869: f3                 popp                   PSW = pop();

Thank you again so much for all of your help... Also I will send a message to my engineering friend and see if he can get me anything that may be helpful. I did ask him a while back about strategy documents, but he wasn't able to find anyone that knew what I was even talking about. LOL. Everyone that was involved in anything like that seems to be retired or at least moved on from FoMoCo. But maybe he can find this info for me.

BOOSTEDEVERYTHING wrote: ↑2024 Jun 06, 08:38 could you please show me an example of how to determine correct size

Previous examples of how to determine correct size;
http://www.efidynotuning.com/forum/view ... 6b9#p13168
http://eectuning.org/forums/viewtopic.p ... 60#p136055
http://eectuning.org/forums/viewtopic.p ... 20#p136291
http://www.efidynotuning.com/forum/view ... 6b9#p13172

Post up a spreadsheet similar to those linked above with jump comments and we can dig into it.

and how to correct it please?

Option 1
DIR

Code: Select all

Sub 8b4b0 "Sub_8b4b0" :UWN :UWN :UY :UY :UY

Option 2
DIR, repeat with changed addresses for every block of args

Code: Select all

args 09e0d 09e13 :UWN :UWN :O 3 UY

RZASA DIR can be updated with this.

Code: Select all

SYM 1AD4E "STCF"                    #[UW]                #              #Seconds<<>>Tick conversion factor {0}

Sorry, I should have looked back to previous posts. It was so early on in this process that I forgot we had already discussed it in detail. So much info involved in this process that it can get a bit overwhelming at times. I will look over those previous posts and will attempt to build a spreadsheet with jump comments for both rzasa and omae2 so we can dig into the arg commands for the above and get that up as soon as I can. Thanks again for the help.

Here are my up to date DIR files, while we are on the subject. I added some things to the RZASA file and I have a couple things written down in a notebook, that I forgot today, that I was going to ask about. I will post back on that possibly tomorrow or tonight. It was a question on a table I think may be defined incorrectly, but I am no positive. Thanks again, I would appreciate any input on my additions, and on my OMAE2 DIR file you may have. I am sure there are a few things wrong with my OMAE2 DIR. I keep getting different address values for a few things and can't seem to make up my mind which are correct. I think I have noted next to some entries and also have left some questionable entries commented out.

Code: Select all

################################ THIS SHOULD BE WUYTB???????#############

SYM 192DA "syTbIECT_NL"                                                 #Engine Temp SCP Correction {2}
TAB 192DA 192FD :O6 SY #[O6 SY=flo(x*1)]     23                           #/>V

Here is one "error" I may have found, not positive on this one, but if you could double check it I would appreciate it? Thanks

I've not had a chance to look at the RZASA changes yet.

The table at that address is unsigned in OMAE2.

Code: Select all

9be98: 45,92,0f,fe,3c     ad3w  R3c,Rfe,f92      TMP5L = uyTb.0x192da;
9be9d: ad,06,38           ldzbw R38,6            TMP3L = 6;
9bea0: 10,08              rombk 8
9bea2: ef,7d,6b           call  82a22            SLU82A22_WUYTb ();

I've consolidated the available sources, fixed some things, but it's pretty hairy.
Quite a lot of duplicates need commenting out. Run it against SAD V5 and check MSG.

Stock_EKO2_256k_DIR_20240609.zip: (112.13 KiB) Downloaded 604 times

EFIDynoTuning Forum

EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion

Re: EEC V file conversion