EFIDynoTuning Forum

Knowledge is Power!
http://forum.efidynotuning.com/

EEC V file conversion

http://forum.efidynotuning.com/viewtopic.php?t=627

Page 38 of 70

Re: EEC V file conversion

Posted: 2024 May 12, 01:17
by jsa
V4.012 DIR for RZASA consolidated from various sources.
Details in header of DIR file.
RZASA_20240512Consolidated.zip
(326.04 KiB) Downloaded 630 times

Re: EEC V file conversion

Posted: 2024 May 13, 05:55
by jsa
BOOSTEDEVERYTHING wrote: ↑2024 May 06, 08:57
Also, I am posting my updated OMAE2 and RZASA dir files that I have added to
No DIR in the RZASA zip you attached.
LST alone is not much use for review.
DIR (and CMT if changed) is all that is required. No need for a copy of SAD to be included.

Looking through the LST you posted, your changes look like stuff that is covered by the RZASA XDF.

The consolidated DIR includes all the XDF stuff, so I'd suggest continuing with the consolidates DIR from here on.
Note what you change with a {7}. Give credit to the source of info or reason for changes, such as strategy name and page.
It would be best to comment out existing lines and add another line for changes you prefer.

I note a couple of immediate inline parameters have names added. That may be intentional or accidental. Without the DIR I can't see if a range was replied. You will see in the consolidated DIR I've elected to comment out Bank 0, 8 & 9 SYM's, with so many of them being immediate values, roughly 1000. SAD won't apply the names in the immediate location usually and may misname other identical values as you have noted yourself. Hopefully a future SAD update will resolve this.

I see you have elected not to use the CMT, you are missing all the info against the Timer structure in LST for starters.

Re: EEC V file conversion

Posted: 2024 May 13, 10:42
by BOOSTEDEVERYTHING
No DIR in the RZASA zip you attached
Sorry about that. Not sure what happened there. I did recently looses a whole buch of things on the usb drive I have been using so maybe something went fluky with that zip file. I attached another with my updated dir and comparison spreadsheet.
I see you have elected not to use the CMT, you are missing all the info against the Timer structure in LST for starters.
I go back and forth using it and not. When I start getting confused I rerun SAD without it until I find my bearings or vice versa. I love the comments but sometimes when comparing 2 bins it gets a little overwhelming.

Re: EEC V file conversion

Posted: 2024 May 14, 05:52
by jsa
BOOSTEDEVERYTHING wrote: ↑2024 May 13, 10:42 I attached another with my updated dir and comparison spreadsheet.
Most of what you added matches up with parameters in Decipha's XDF, so that is good.

I see you have some additional parameters, so I've added those to the consolidated DIR attached below.
Continue on with the consolidated DIR below.
RZASA_20240514Consolidated.zip
(194.37 KiB) Downloaded 618 times

Re: EEC V file conversion

Posted: 2024 May 14, 11:21
by BOOSTEDEVERYTHING
Awesome!! Will do, Thanks. I will let you know if I come across anything else so you can add it in. I noticed it is very complete though so I most likely won't find anything else. LOL. Thanks very much for putting this dir together. Just have to get used to the formatting of it again. Is this a better way to format the dir file for the future or should I continue on with how I have been doing things?

Re: EEC V file conversion

Posted: 2024 May 14, 20:10
by jsa
You can add stuff yourself. Just post up the changes or the updated DIR. There is still some stuff to be found and lots of stuff to be identified.

The format is arranged with making it easier to convert from DIR to a definition in mind. That's a moving target.
When you look at definitions from BE and TP, they both follow
Once V5 is more usable changes will be made to suit such as :UW becomes [UW] or [UW flo=x*42] or whatever.
Could well change it all again. Time will tell.

Symbols, tables and function are parameters that go into a definition, the rest of it is stuff to make SAD work that does not go in a definition.
Special function registers are not editable and of little logging value.
RAM is not editable but holds logging targets.
ROM is editable.

The earlier RZASA dir's I've posted have been a bit disorganised as they were basically DMR conversion with stuff thrown in for testing, so better organised now.

Yes you should keep it organised.

Re: EEC V file conversion

Posted: 2024 May 15, 09:53
by BOOSTEDEVERYTHING
The one thing I need some clarification on is the math on some of the ones I am finding in OMAE2. I suspect that the code is calling a hex value in an RBase location and adding a hex value to that to it to come up with a value, Is that correct for the below? If that is the casse, how would I go about finding the actual Rbase value stored in Ree? Thanks
OMAE2:

Code: Select all

95b43: 11,2f              clrb  R2f              TEMP5H = 0;
95b45: 8f,ee,20,2c        divw  R2c,[Ree+20]     TEMP4L /= [Ree+20];
95b49: d5,05              jnv   95b50            if (OVF = 1)  {
95b4b: a0,00,2c           ldw   R2c,R0           TEMP4L = ZERO;
95b4e: 20,25              sjmp  95b75            goto 95b75; }

Code: Select all

   Sub_9635b:
9635b: f2                 pushp                  push(PSW);
9635c: b3,fb,93,00,36     ldb   R36,[Rfa+93]     TMP2L = NUMCYL_0;
96361: 99,04,36           cmpb  R36,4            
96364: d7,0a              jne   96370            if (TMP2L = 4)  {
96366: a3,ee,12,2e        ldw   R2e,[Ree+12]     TEMP5L = [Ree+12];
9636a: a3,ee,10,2c        ldw   R2c,[Ree+10]     TEMP4L = [Ree+10];
9636e: 20,26              sjmp  96396            goto 96396; }

96370: 99,06,36           cmpb  R36,6            
96373: d7,0a              jne   9637f            if (TMP2L = 6)  {
96375: a3,ee,16,2e        ldw   R2e,[Ree+16]     TEMP5L = [Ree+16];
96379: a3,ee,14,2c        ldw   R2c,[Ree+14]     TEMP4L = [Ree+14];
9637d: 20,17              sjmp  96396            goto 96396; }

9637f: 99,08,36           cmpb  R36,8            
96382: d7,0a              jne   9638e            if (TMP2L = 8)  {
96384: a3,ee,1a,2e        ldw   R2e,[Ree+1a]     TEMP5L = [Ree+1a];
96388: a3,ee,18,2c        ldw   R2c,[Ree+18]     TEMP4L = [Ree+18];
9638c: 20,08              sjmp  96396            goto 96396; }

9638e: a3,ee,1e,2e        ldw   R2e,[Ree+1e]     TEMP5L = [Ree+1e];
96392: a3,ee,1c,2c        ldw   R2c,[Ree+1c]     TEMP4L = [Ree+1c];
96396: 9b,fb,93,00,00     cmpb  R0,[Rfa+93]      
9639b: df,4a              je    963e7            if (NUMCYL_0 != ZERO)  {
Suspect it compares to RZASA:

Code: Select all

98c36: 11,2f              clrb  R2f              TEMP5H = 0;
98c38: 8f,ce,50,2c        divw  R2c,[Rce+50]     TEMP4L /= S.0x1AD6E;
98c3c: d5,05              jnv   98c43            if (OVF = 1)  {
98c3e: a0,00,2c           ldw   R2c,R0           TEMP4L = ZERO;
98c41: 20,26              sjmp  98c69            goto 98c69; }

Code: Select all

   Sub_993aa:
993aa: f2                 pushp                  push(PSW);
993ab: b3,fa,22,36        ldb   R36,[Rfa+22]     TMP2L = NUMCYL_0;
993af: 99,04,36           cmpb  R36,4            
993b2: d7,0a              jne   993be            if (TMP2L = 4)  {
993b4: a3,ce,42,2e        ldw   R2e,[Rce+42]     TEMP5L = S.0x1AD60;
993b8: a3,ce,40,2c        ldw   R2c,[Rce+40]     TEMP4L = S.0x1AD5E;
993bc: 20,26              sjmp  993e4            goto 993e4; }

993be: 99,06,36           cmpb  R36,6            
993c1: d7,0a              jne   993cd            if (TMP2L = 6)  {
993c3: a3,ce,46,2e        ldw   R2e,[Rce+46]     TEMP5L = S.0x1AD64;
993c7: a3,ce,44,2c        ldw   R2c,[Rce+44]     TEMP4L = S.0x1AD62;
993cb: 20,17              sjmp  993e4            goto 993e4; }

993cd: 99,08,36           cmpb  R36,8            
993d0: d7,0a              jne   993dc            if (TMP2L = 8)  {
993d2: a3,ce,4a,2e        ldw   R2e,[Rce+4a]     TEMP5L = S.0x1AD68;
993d6: a3,ce,48,2c        ldw   R2c,[Rce+48]     TEMP4L = S.0x1AD66;
993da: 20,08              sjmp  993e4            goto 993e4; }

993dc: a3,ce,4e,2e        ldw   R2e,[Rce+4e]     TEMP5L = S.0x1AD6C;
993e0: a3,ce,4c,2c        ldw   R2c,[Rce+4c]     TEMP4L = S.0x1AD6A;
993e4: 9b,fa,22,00        cmpb  R0,[Rfa+22]      
993e8: df,45              je    9942f            if (NUMCYL_0 != ZERO)  {

Re: EEC V file conversion

Posted: 2024 May 16, 00:03
by jsa
Locate where the base value is set for REE, then set an Rbase accordingly.

Hint, search LST for REE.

Re: EEC V file conversion

Posted: 2024 May 16, 08:22
by BOOSTEDEVERYTHING
I did search for REE in LST file and found this in the CALINIT subroutine at L_823E2 and when you follow up to L_823DA you find B302, but I wasn't sure if that was correct or not?

Code: Select all

 CalInit:
82375: 11,1b              clrb  R1b              CAM_SLOTS_AVBL = 0;
82377: a1,80,02,d2        ldw   Rd2,280          TSLAMU1 = 280;
8237b: a1,80,03,d4        ldw   Rd4,380          CANP_FF = 380;
8237f: a1,80,05,d6        ldw   Rd6,580          Rd6 = 580;
82383: a1,80,08,d8        ldw   Rd8,880          ECT_ACT_DIFF = 880;
82387: a1,80,09,da        ldw   Rda,980          Rda = 980;
8238b: a1,80,0a,dc        ldw   Rdc,a80          Rdc = a80;
8238f: a1,80,10,de        ldw   Rde,1080         Rde = 1080;
82393: a1,80,11,e0        ldw   Re0,1180         Re0 = 1180;
82397: a1,80,12,e2        ldw   Re2,1280         TRIP_MON_LST = 1280;
8239b: a1,80,13,e4        ldw   Re4,1380         SCP_COOL_OLD = 1380;
8239f: a1,80,14,e6        ldw   Re6,1480         ODU_KEY = 1480;
823a3: a1,80,15,e8        ldw   Re8,1580         Re8 = 1580;
823a7: a1,80,16,ea        ldw   Rea,1680         ENG_ROT_TMR_? = 1680;
823ab: a1,80,17,ec        ldw   Rec,1780         Rec = 1780;
823af: a1,02,b3,46        ldw   R46,b302         TMP0L = SBTR_18MHZ_default;
823b3: b3,f4,07,36        ldb   R36,[Rf4+7]      TMP2L = [125a5];
823b7: b3,f4,06,34        ldb   R34,[Rf4+6]      TMP1L = AICE_?x8;
823bb: 99,02,34           cmpb  R34,2            
823be: df,22              je    823e2            if (TMP1L != 2)  {
823c0: a1,86,b3,46        ldw   R46,b386         TMP0L = SBTR_21MHZ;
823c4: b3,f4,08,36        ldb   R36,[Rf4+8]      TMP2L = [125a6];
823c8: 99,04,34           cmpb  R34,4            
823cb: df,15              je    823e2            if (TMP1L != 4)  {
823cd: a1,0a,b4,46        ldw   R46,b40a         TMP0L = SBTR_24MHZ;
823d1: b3,f4,09,36        ldb   R36,[Rf4+9]      TMP2L = [125a7];
823d5: 99,06,34           cmpb  R34,6            
823d8: df,08              je    823e2            if (TMP1L != 6)  {
823da: a1,02,b3,46        ldw   R46,b302         TMP0L = SBTR_18MHZ_default;
823de: b3,f4,07,36        ldb   R36,[Rf4+7]      TMP2L = [125a5]; } } }
823e2: c0,ee,46           stw   R46,Ree          Ree = TMP0L;
823e5: c7,d2,4b,36        stb   R36,[Rd2+4b]     SPI_BIT_TRANSFER_RATE = TMP2L;
823e9: b1,c1,46           ldb   R46,c1           TMP0L = c1;
823ec: 9b,f9,a8,00,00     cmpb  R0,[Rf8+a8]      
823f1: df,03              je    823f6            if (knk_sensors != ZERO)  {
823f3: 91,02,46           orb   R46,2            B1_TMP0L = 1; }
823f6: b0,46,0c           ldb   Rc,R46           HSI_MASK = TMP0L;
823f9: b0,00,1a           ldb   R1a,R0           HSI_EDGE_MODE = ZERO;
823fc: b1,04,72           ldb   R72,4            R72 = 4;
823ff: 34,c4,03           jnb   B4,Rc4,82405     if (SCP_UP = 1)  {
82402: 91,02,72           orb   R72,2            B1_R72 = 1; }
82405: f2                 pushp                  push(PSW);
82406: fa                 di                     interrupts OFF;
82407: c4,08,72           stb   R72,R8           IO_INT_MASK = R72;
8240a: a1,ff,03,12        ldw   R12,3ff          HSO_INT_1_MASK = 3ff;
8240e: a1,40,80,16        ldw   R16,8040         HSO_INT_2_MASK = 8040;
82412: f3                 popp                   PSW = pop();
82413: 71,ef,54           an2b  R54,ef           RAMINIT_Flg = 0;
82416: f0                 ret                    return;

Re: EEC V file conversion

Posted: 2024 May 16, 08:30
by BOOSTEDEVERYTHING
Also wanted to ask if it would be beneficial to copy over the commented out part of the DIR file to my DIR file? Example below..

Code: Select all

SYM 17800 "FIECT_3_SH"              #[SY=flo(X/0.5)]     #deg F         #IOET ECT Min {2}
#SYM17800 "S.0x17800"               #[SY=flo(X*1)]       #              # {3}
I found the FIECT_3_SH, Would it benefit me in the future to have the next line from the same address copied over and left commented out? Also, what does the {2} and {3} and {1} stand for after the entries?
All times are UTC-04:00
Page 38 of 70

Powered by phpBB® Forum Software © phpBB Limited