EFIDynoTuning Forum

I will give it a try without the dir and cmt files and see what I get.
EDIT: Yep, that worked. must be something about my dir file it doesn't like. I will go through it this weekend some more and double check for duplicates, and just delete the entries I have edited out with a # at the start of the line. I have a ton of garbled up mess in my dir file, I keep going back and changing things as I find them and sometimes I keep going back and forth questioning my choices. Also the dir works with v4.16b but maybe isn't completely compatible with v5, so I will check my entries with the V5 command list.
EDIT: SAD V5.0.2 definitely crashes with my dir file. The dbg file ends very abruptly with this

Code: Select all

Branch start 9bd56 17 [2e 0] (0 1) 9bd53[16] 9bd50[15

Without the dir file it continues on and I get this line in the same location and way more...

Code: Select all

Branch start 9bd56 17 [2e 0] (0 1) 9bd53[16] 9bd50[15] 9bd4b[14] 9bd48[13] 9bd45[12] 9bd42[11] 9bd3e[10] 9bd3b[9] 9bd38[8] 9bd33[7] 9bd30[6] 9bd2c[5] 9bd29[4] 9bd25[3] 9bd23[2] 9bd20[1]END 9bd1d  9bd5e[16] 9bd5c[15] 9bd58[14] 9bd56[13] 9bd53[12] 9bd50[11] 9bd4b[10] 9bd48[9] 9bd45[8] 9bd42[7] 9bd3e[6] 9bd3b[5] 9bd38[4] 9bd33[3] 9bd30[2] 9bd2c[1]END 9bd29 
End call branch 9bd6b

Fixed a list of stuff reported, and released it as 5.0.3. More to do, but hope that fixes make SAD more useful right now.

Thanks for your responses to help make this a better product.

Thank you for the new release.

Yes, Thank You! Without this software we would be lost. And Everyone's help, of course.

EDIT: I just tried it with a DIR file and get empty msg and lst files. The post above where it shows where the dbg file stops, is that a clue for me to fix something in my dir file that may be stopping SAD from finishing the disassembly? If so, Where do I start looking? Thanks again very much for all of your hard work.

$ ./SAD_5.0.3.exe KID2
Segmentation fault

Not good.
Sure would be nice if you used the GIT repository the way it is meant to be used, so other developers could see the changes, and compare diff.
I know I've asked before, and you've answered me before.
I sure would like to contribute, but not committing changes to the git repo makes it impossible to share code and for others to fix bugs.
Just my opinion.

I created a pull request:

Code: Select all

 
Development/NEW*NEW version 5 readme.txt → Development/NEW-NEW version 5 readme.txt

Asterisk * in the file name prevents git clone working.

The program seg faults same location as pre 5.0.3.
Screen shots attached:

Here is a full back trace:

Code: Select all

Reading symbols from sad.exe...
Starting program: sources\5.0.3\sad.exe
[New Thread 11492.0x2bb8]
KID2

Thread 1 received signal SIGSEGV, Segmentation fault.
add_spf_register (p=0xaa6ba8, dest=58, sce=0, popaddr=622135)    at sources\5.0.3\core.cpp:6191
6191      if (!get_spf(vconv(p->argblk[1]->nextaddr)))

#0  add_spf_register (p=0xaa6ba8, dest=58, sce=0, popaddr=622135)    at sources\5.0.3\core.cpp:6191
#1  0x00007ff6df544f9c in ldx (s=0x9b3540, c=0x7ff6df573ca0 <einst>)    at sources\5.0.3\core.cpp:6508
#2  0x00007ff6df547b1a in do_code (s=0x9b3540, c=0x7ff6df573ca0 <einst>)    at sources\5.0.3\core.cpp:8093
#3  0x00007ff6df5427ed in scan_blk (s=0x9b3540, c=0x7ff6df573ca0 <einst>)    at sources\5.0.3\core.cpp:3681
#4  0x00007ff6df546d62 in scl (s=0x9b3270, c=0x7ff6df573ca0 <einst>)    at sources\5.0.3\core.cpp:7566
#5  0x00007ff6df547b1a in do_code (s=0x9b3270, c=0x7ff6df573ca0 <einst>)    at sources\5.0.3\core.cpp:8093
#6  0x00007ff6df5427ed in scan_blk (s=0x9b3270, c=0x7ff6df573ca0 <einst>)    at sources\5.0.3\core.cpp:3681
#7  0x00007ff6df5429c0 in emulate_blk (addr=623014, caller=0xab3b90)    at sources\5.0.3\core.cpp:3852
#8  0x00007ff6df546a78 in do_sub_scan (caller=0xab3b90, c=0x7ff6df573be0 <cinst>)    at sources\5.0.3\core.cpp:7421
#9  0x00007ff6df546ca5 in scl (s=0xab3b90, c=0x7ff6df573be0 <cinst>)    at sources\5.0.3\core.cpp:7526
#10 0x00007ff6df547b1a in do_code (s=0xab3b90, c=0x7ff6df573be0 <cinst>)    at sources\5.0.3\core.cpp:8093
#11 0x00007ff6df5427ed in scan_blk (s=0xab3b90, c=0x7ff6df573be0 <cinst>)    at sources\5.0.3\core.cpp:3681
#12 0x00007ff6df54819a in scan_all ()    at sources\5.0.3\core.cpp:8506
#13 0x00007ff6df54ad9f in disassemble (fstr=0xaa6510 "KID2")    at sources\5.0.3\core.cpp:10565
#14 0x00007ff6df54beee in main (argc=1, argv=0xaa3d30)    at sources\5.0.3\main.cpp:593

Well, I commented out line# 6508 in core.cpp, and it works!!

I have no idea what the following does, but for single bank its good.

Code: Select all

6508: //add_spf_register(p, o->addr, 0, c->opr[1].addr);

Spoke too soon.
Works with no dir file, and with a dir file it seg faults still.

I am sorry, I spoke too soon as well, with a dir file I got a partial lst file and an empty msg file. No debug file this time. My lst file seems to end with a few func listings and then just stops. Is there a way to tell what made the program crash?
EDIT: Never mind. I went into my DIR file and commented out the functions list i had and the program completed the run. I got msg file and lst file. I did get a few errors for duplicate commands that I have to go in and check on, but other than that I need to look at the new documentation and see if something with how those functions are defined is not compatible with the new SAD. Great job on the error corrections in the software!! The rest is most likely me or outdated commands in my dir file.

These are my errors and will report back if it was my doing or maybe a bug. Thanks again!!!

Code: Select all

## SYM  0015 "AICE_A_D_CTRL"          [W ][B4 ]
   ## Error - too many [data] items specified

## SYM  0015 "AICE_A_D_WR"            [W ][B5 ]
   ## Error - too many [data] items specified

## SYM  0015 "AICE2_WRITE"            [W ][B7 ]
   ## Error - too many [data] items specified

## SYM  005C "WORD_POINTER"               
   ## Error - Duplicate Command

## SYM  008C "RX_DATA"                    [B1 ]
   ## Error - Duplicate Command

## SYM  00AB "PIP_INT"                    [B0]
   ## Error - Duplicate Command

## SYM  00CE "OV_DOWN"                    [B0 ]
   ## Error - Duplicate Command

## SYM  00CE "OV_UP"                      [B1 ]
   ## Error - Duplicate Command

## SYM  081C "CAT_CNT_GAS"                
   ## Error - Duplicate Command

## SYM  0826 "CODES_COUNT"                
   ## Error - Duplicate Command

## SYM  082E "ISCKAM0"                    
   ## Error - Duplicate Command

## SYM  0900 "P0112_RECORD"               
   ## Error - Duplicate Command

## SYM  0902 "P0113_RECORD"               
   ## Error - Duplicate Command

## SYM  0F63 "TOD_TVCT_LST"               
   ## Error - Duplicate Command

## SYM  1010 "OSC_ENA8"                   
   ## Error - Duplicate Command

## SYM  12B4 "GR_CM_SCP"                  
   ## Error - Duplicate Command

## SYM  12B5 "GR_DS"                      
   ## Error - Duplicate Command

## SYM  12FC "DESMAF_PRE"                 
   ## Error - Duplicate Command

## SYM  14D1 "FLG_PWR_TQ"                 [B5 ]
   ## Error - Duplicate Command

## SYM  14D1 "IS_COM_ERROR"               [B6 ]
   ## Error - Duplicate Command

EFIDynoTuning Forum

SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)

Re: SAD Version 5 (alpha)