SAD Version 5 (alpha)

[BOOSTEDEVERYTHING]

TVRFAN.... I am not sure if it is possible, or how complicated it would be, Is there a way you could have sad give a message for duplicate label names as well? Just a note in the msg file would be awesome. I really like the duplicate op code warnings, it helped me to correct my dir file a good bit. The duplicate label names would be great to have as well. Not so much where it will not execute the command if the label name is a duplicate but, just a note in the msg file would be super helpful to me at least, and maybe others starting out would benefit as well. I know there are other things that need to be fixed first but I figured I would ask. Thank you so much again for all of your efforts.

NOTE: I have also noticed that SAD V5.0.3 does not disassemble all of the RZASA bin either. I will post a copy of the bin I am using for reference. It is the one that JSA gave me for comparison to my EQE3 bin

[tvrfan]

You mean like a "name2" is duplicate of "name1" ?? yep, could look at that..........
I was wondering if it should apply for other commands too, like " Word 1234 overlaps with byte 1235" , where it makes sense.
(note that code -> code or word ->word etc. will just get merged together)

General - if you get a crash with a command (dir file), and not if you remove it, it's possible the crash is when parsing the command, or what you're asking for breaks SAD. So I might ask for your dir file if I can't find why. With Windows, a program can just disappear... I may have to add a "type any char to continue" so you can read what happened..

I want SAD to never break - even if you feed it garbage it should reject it with an error, not crash.

missed parts - SAD can't always get all the code and data out by scanning, as there are what I call 'sneaky' tricks. (it's perfectly legal code to write, just very hard to process automatically). I did do a scan of the 'gaps' in some v4, but I switched it off because it produced a lot of 'false code' which was actually data. (no it's not always easy to tell the difference...). So for now, yes, may miss bits. Intend to put that back later, also some better table fixes.
if you are sure a block is code, you can do
SCAN <address>
to kick of processing for that block, and anything else that block CALLS as subroutines.... if it's not code it (should) will mark it as invalid and continue.

Still working though bugs............

[tvrfan]

Code: Select all

FUN 12254 122CB "uuwFn036_MAF_Transfer" :W V 13107 :W V +1 P +5      # Mass Air Flow meter transfer function. CDAN 24-6

Can't see anything wrong in there - or with jamie's commands.
tried them out but it doesn't crash for me ........
Guys, do you know if SAD starts processing and THEN fails ?? if so it's doing something wrong in the data processing, not the command processing.

......OK more digging to do.

NB. I think I've found crash reported by jsa, KID2 etc.

[BOOSTEDEVERYTHING]

My EQE3 bin goes through pretty good without that MAF transfer func in the dir. Other than the missing orb commands I do not see anything else so far. The RZASA bin on the other hand misses huge sections of code even without the dir file.
The name thing is exactly what I am talking about. If it is not a huge deal to implement it would be a huge help for new people like me. I keep finding myself adding duplicate entries at different addresses and I end up finding the mistake later rather than sooner. The overlap thing would be really helpful for me as well. Especially because I have not committed all the "rules" to memory yet. Also, the press any key to continue thing is a good idea. Sometimes it finishes so fast I miss whether it actually finished or crashed.

[Jamie from oz]

Sad 503 was processing stage 2 output and stopped then the MSG file was blank and LST was huge compared to normal 900k file.
I looked in the LST and where it stopped processing the code I commented all functions after that.
I ran it and all worked well then added the 30 odd functions until I isolated the ones I posted that caused the problem.
I will post the bin and dir file.

[jsa]

TVRFAN.... I am not sure if it is possible, or how complicated it would be, Is there a way you could have sad give a message for duplicate label names as well?

Just keep in mind, multiple Sym names can be valid, for different addresses or address ranges.
A global setting to silence the 'message' would be welcome.

NOTE: I have also noticed that SAD V5.0.3 does not disassemble all of the RZASA bin either.

It disassembles for me, using the DIR and CMT, though it complains a lot about duplicates from the DMR source.
It also disassembles without DIR and CMT, debugging is so much fun.
Are you saying some code is overlooked without SCAn commands?

Right click on you copy of RZASAMY.bin
Then click on properties, is there a block or unblock button at the bottom of the dialog?

My EQE3 bin goes through pretty good without that MAF transfer func in the dir.

The attached has the MAF function included and works...some sort of combo bug with yours it seems.
Start with only the MAF function in place then add other stuff back in until it fails.

EQE3.zip

(114.8 KiB) Downloaded 39 times

Other than the missing orb commands I do not see anything else so far. The RZASA bin on the other hand misses huge sections of code even without the dir file.

There are a lot of SCA commands in the DIR I uploaded, so not having them will likely leaves code overlooked. The question is, is it better or worse than earlier versions. Huge progress has been made over the years but more to do obviously.

[jsa]

I was wondering if it should apply for other commands too, like " Word 1234 overlaps with byte 1235" , where it makes sense.

As TVRfan and I have previously discussed, SFR's have valid byte and word addresses overlapping.

Some of the duplicates in RZASA and by association EQE3 etc, at RAM addresses, are bytes and words with different names and overlapping addresses. These come from the DMR file. The byte is a subset of the word. I see in the SAD manual that Byte is there with Write, so I'll be giving that a run on RZASA in due course.

'Where it makes sense' is a tricky one.

[Jamie from oz]

sadv503_6dbd_56k_x.bin

(56 KiB) Downloaded 38 times

not sure why i cant add the dir file so i will zip it and try again

[BOOSTEDEVERYTHING]

Right click on you copy of RZASAMY.bin
Then click on properties, is there a block or unblock button at the bottom of the dialog?

I do not see anything about block or unblock. There is a read only dialog but it is unchecked.

Just keep in mind, multiple Sym names can be valid, for different addresses or address ranges.
A global setting to silence the 'message' would be welcome.

Yes. I was trying to say that as well but probably not worded quite right. LOL

Are you saying some code is overlooked without SCAn commands?

This could be what is going on. Maybe I should keep my fingers off the keyboard as far as bug reporting goes, LOL. I hope I haven't confused anything or caused un-needed debugging. I am attaching a copy of the lst file I got when I used RZASA bin and no dir file with sad v5.0.3 so you can see what I am talking about.
I am trying to be helpful and give back as much as I can ,but my comments may be way off base, please take what I say with a grain of salt if it seems like something may be off base.

The attached has the MAF function included and works...some sort of combo bug with yours it seems.
Start with only the MAF function in place then add other stuff back in until it fails.

I will give that a shot and report back when/if it fails as I add things back in. It may help for me to do this anyways. It may assist in cleaning up my dir file a bit.
EDIT: Well I tried that and it did not complete the disassembly process. I got an incomplete lst file and a blank msg file. Can you please post the SAD V5.0.3 exe file you are using? maybe something is wrong with the one I downloaded from github? I should note that I am using a windows 10 based computer, and the drag and drop method. all files are in the same directory. I am using a thumb drive with the files on it so I can go back and forth to work with it. maybe something wrong with that setup?

On a side note: have you verified the entries in the dir file you posted are correct? Not sure if that is the one I sent you or the one you are working with? Thanks, just trying to get a read on how I am doing as far as correct entries.

[jsa]

Are you saying some code is overlooked without SCAn commands?

This could be what is going on. Maybe I should keep my fingers off the keyboard as far as bug reporting goes, LOL.

Keep going, discussion on what you see is the only way to make progress.

Can you please post the SAD V5.0.3 exe file you are using?

I could, but the king is dead, long live the king...

TVRfan has posted 5.04 on github, so eat, test, sleep, repeat.

On a side note: have you verified the entries in the dir file you posted are correct? Not sure if that is the one I sent you or the one you are working with?

It is a mix of the one you posted and the one I was working with.
Some of it has been checked but not all of it yet.